Skip to content

docs(skills): decouple work item closure from commits#39

Merged
lucifer1004 merged 1 commit into
mainfrom
dev
Jul 21, 2026
Merged

docs(skills): decouple work item closure from commits#39
lucifer1004 merged 1 commit into
mainfrom
dev

Conversation

@lucifer1004

@lucifer1004 lucifer1004 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Updated governed workflow guidance to maintain work-item traceability across substantive implementation, including commits linked to work items already marked done.
    • Clarified how the “active work item” check is used (as a pre-implementation gate) and improved branching guidance when an active item doesn’t apply.
    • Refined quick workflow steps: acceptance criteria completion now happens before recording changes.
    • Updated instructions to bundle any work-item closure notes with the implementation commit by default, removing the separate closure-record step.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bccd3300-134c-4ca2-9a0e-1ad0968fe49e

📥 Commits

Reviewing files that changed from the base of the PR and between 801a2fa and beb2564.

📒 Files selected for processing (3)
  • .claude/skills/commit/SKILL.md
  • .claude/skills/gov/SKILL.md
  • .claude/skills/quick/SKILL.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • .claude/skills/quick/SKILL.md
  • .claude/skills/commit/SKILL.md

📝 Walkthrough

Walkthrough

Updated skill documentation to align work-item traceability, completion timing, and commit recording. Completed work items may remain linked to implementation commits, while work-item closure is completed before and recorded with the final implementation commit.

Changes

Work-item traceability workflows

Layer / File(s) Summary
Traceability policy and commit guidance
.claude/skills/commit/SKILL.md, .claude/skills/gov/SKILL.md
Commit guidance now checks pending work items before completed items, preserves traceability to the governing active or completed item, and defines active-item checks as pre-implementation gates.
Work-item finalization and commit ordering
.claude/skills/commit/SKILL.md
Closure-worthy notes, acceptance criteria, and done transitions are finalized before the implementation commit; post-commit closure updates are removed and common scenarios are aligned.
Quick workflow completion and recording
.claude/skills/quick/SKILL.md
The workflow now completes the work item before recording the commit and includes closure in the same commit by default.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main docs update around work-item closure and commit traceability, even if it is a bit broader than the exact workflow changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/skills/commit/SKILL.md:
- Around line 191-212: Update Step 7 in the commit workflow to remove the
post-commit instruction to move the work item to done. Explicitly state that
work-item closure must already be completed and included before invoking
/commit, keeping it consistent with the pre-commit closure sequence in Scenario
1.
- Line 193: Add the text language identifier to the two unlabeled fenced code
blocks containing the numbered workflow examples in the commit skill
documentation, including both locations referenced by the review, so they
satisfy MD040.
- Around line 50-52: Update Step 3’s work-item lookup to include completed items
by invoking the supported `govctl work list done` command or equivalent
all-items filter alongside the existing pending lookup. Ensure the
no-active-work path can inspect completed work items matching the diff while
preserving the queued and active checks.

In @.claude/skills/quick/SKILL.md:
- Around line 93-96: Update the “Complete” step to move a work item to done only
after all acceptance criteria are satisfied, not merely after ticking matching
criteria. Keep the item active when any criterion remains incomplete, and
preserve the instruction to skip this step when no work item was used.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 364d5790-cac7-4cc0-aed5-9c3a8f1388c0

📥 Commits

Reviewing files that changed from the base of the PR and between 0272218 and 801a2fa.

📒 Files selected for processing (3)
  • .claude/skills/commit/SKILL.md
  • .claude/skills/gov/SKILL.md
  • .claude/skills/quick/SKILL.md

Comment thread .claude/skills/commit/SKILL.md
Comment thread .claude/skills/commit/SKILL.md
Comment thread .claude/skills/commit/SKILL.md Outdated
Comment thread .claude/skills/quick/SKILL.md
@lucifer1004
lucifer1004 merged commit c5abad0 into main Jul 21, 2026
8 checks passed
@lucifer1004
lucifer1004 deleted the dev branch July 21, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant