docs(skills): decouple work item closure from commits#39
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdated skill documentation to align work-item traceability, completion timing, and commit recording. Completed work items may remain linked to implementation commits, while work-item closure is completed before and recorded with the final implementation commit. ChangesWork-item traceability workflows
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/commit/SKILL.md:
- Around line 191-212: Update Step 7 in the commit workflow to remove the
post-commit instruction to move the work item to done. Explicitly state that
work-item closure must already be completed and included before invoking
/commit, keeping it consistent with the pre-commit closure sequence in Scenario
1.
- Line 193: Add the text language identifier to the two unlabeled fenced code
blocks containing the numbered workflow examples in the commit skill
documentation, including both locations referenced by the review, so they
satisfy MD040.
- Around line 50-52: Update Step 3’s work-item lookup to include completed items
by invoking the supported `govctl work list done` command or equivalent
all-items filter alongside the existing pending lookup. Ensure the
no-active-work path can inspect completed work items matching the diff while
preserving the queued and active checks.
In @.claude/skills/quick/SKILL.md:
- Around line 93-96: Update the “Complete” step to move a work item to done only
after all acceptance criteria are satisfied, not merely after ticking matching
criteria. Keep the item active when any criterion remains incomplete, and
preserve the instruction to skip this step when no work item was used.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 364d5790-cac7-4cc0-aed5-9c3a8f1388c0
📒 Files selected for processing (3)
.claude/skills/commit/SKILL.md.claude/skills/gov/SKILL.md.claude/skills/quick/SKILL.md
Summary by CodeRabbit