[GOVCMS-14555] Added HTTPAV identifier.#552
Open
barbun wants to merge 1 commit into
Open
Conversation
Ali-Haider-24
force-pushed
the
4.x-develop
branch
from
17ae1fd to
be80149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
HTTPAV Drupal module has support of
X-Requester-IDheader. If set, this header is then used by the AV service to supplement logs to better identify which environment instance the logs belong to. Currently, it is impossible to correlate the logs to instances.The value of the header is controlled via
HTTPAV_IDENTIFIERenvironment variable, which is currently not set for any of instances on GovCMS.Proposed solution
Enhance PHP dockerfile to introduce a new PHP-FPM config that evaluates
HTTPAV_IDENTIFIERat the container start as a concatenation of existingLAGOON_PROJECTandLAGOON_ENVIRONMENTvars (e.g.projectName-develop), which will provide a meaningful information to the logs to identify the instance when invoking the AV service.