Repository navigation
feat(ENGKNOW-3999): throwif -m <message> and offending row in error - #153
Merged
Merged
Conversation
-m replaces the default "Gor throw on: <condition>" message with a literal (quoted) string. -d adds the header and the row that triggered the throw to the error via GorDataException's header/row support. In nor context the internal ChromNOR/PosNOR columns are left out. Options combine with each other and with -retriable; default behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gmagnu
marked this pull request as ready for review
October 6, 2026 22:03
-d formatted the header and row into the message while ExceptionUtilities also appends getHeader()/getRow(), so they were printed twice. The option is not needed; remove it. Use stringValueOfOptionWithDefault for -m. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gmagnu
changed the title
The GorDataException now carries the header and the row that triggered the throw, built with doFormat=false so getMessage() stays the plain message and ExceptionUtilities renders Header/Row once. In nor context the internal ChromNOR/PosNOR columns are left out. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gmagnu
changed the title
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
bragnarsson
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENGKNOW-3999:
-m <message>— use a literal (quoted) message instead ofGor throw on: <condition>. Works with-retriable.GorDataExceptionnow always carries the header and the offending row. It is built withdoFormat=false, sogetMessage()stays the plain message andExceptionUtilitiesrendersHeader:/Row:once. In nor context the internalChromNOR/PosNORcolumns are omitted.The
-doption from the ticket is not needed: the row is always attached.→
Needed for
variant_liftover/interval_liftoverraise mode (ENGKNOW-3942).Tests
UTestThrowIfAnalysis: custom message (+ header/row), custom message + retriable.UTestThrowIf(query level): default message unchanged,-m, message with spaces/quotes, only the offending row attached, rendered error shows Header/Row exactly once, with-retriable, nor context.throwif— all pass.Docs:
documentation/src/command/THROWIF.rstupdated.🤖 Generated with Claude Code