fix: prevent locked scroll re-entry - #2760
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2737.
On iOS Fabric,
scrollTomay synchronously emit another scroll or momentum-end event. While the scrollable remainsLOCKED, the default handlers callscrollToagain on that same native stack until it overflows.This change adds one shared-value re-entrancy guard around the three locked-state
scrollTocall sites. The outer command and existing offset updates are preserved; only nested commands are skipped. The guard is released infinallyso an error cannot leave the scrollable permanently locked.Verification
yarn test— 2/2 regression tests pass (re-entry is bounded; lock is released after errors)yarn typescript— passyarn biome check --error-on-warnings package.json src/hooks/executeWithLock.ts src/hooks/useScrollEventsHandlersDefault.ts tests/executeWithLock.test.cjs— passyarn build— pass for CommonJS, module, and TypeScript targetsFull
yarn lintstill reports the existinguseOptionalChainwarning insrc/hooks/useBoundingClientRect.ts:54; that file is unchanged frommaster.