fix: omit native scroll handler dependencies - #2759
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2758.
Reanimated 4.6 warns whenever native
useAnimatedScrollHandlerreceives a dependency array because that argument is only intended for web builds without the Worklets Babel plugin. Bottom Sheet already resolvesuseScrollHandler.web.tson web, souseScrollHandler.tsis the native implementation and does not need the second argument.This removes only the native dependency array. The handler closures and existing platform-specific web implementation remain unchanged.
Verification
2, then passed with1yarn test— 1 passedyarn typescript— passedyarn build— CommonJS, module, and declarations passed; built native output callsuseAnimatedScrollHandlerwith one argumentThe repository-wide
yarn lintcommand still reports one existing warning in unchangedsrc/hooks/useBoundingClientRect.ts:54(useOptionalChain); this PR adds no lint findings.I intentionally did not migrate the existing
runOnJScalls here: the package still supports Reanimated 3 and does not declarereact-native-workletsas a peer, so that compatibility migration is separate from this warning-only fix.