fix: preserve content when toggling panning gesture - #2752
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
vatsal-jain-intangles
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Motivation
Changing
enableContentPanningGesturecurrently swaps the content wrapper betweenBottomSheetDraggableViewandAnimated.View. Since those are different component types, React unmounts and remounts the entire content subtree when the prop changes.Keep
BottomSheetDraggableViewas the stable wrapper. It already rebuilds its pan gesture with.enabled(enableContentPanningGesture), so gesture behavior remains dynamic without replacing the content tree.Closes #2733.
Verification
yarn typescriptyarn buildyarn biome check --error-on-warnings src/components/bottomSheet/BottomSheetContent.tsxgit diff --checkThe repository-wide
yarn lintstill reports the existing unrelated optional-chain warning insrc/hooks/useBoundingClientRect.ts:54.