fix: update maintenance mode route dependency#1485
Open
goravel-coder wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1485 +/- ##
==========================================
+ Coverage 69.27% 69.37% +0.09%
==========================================
Files 377 377
Lines 29613 29622 +9
==========================================
+ Hits 20515 20549 +34
+ Misses 8152 8128 -24
+ Partials 946 945 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Applications that use route middleware expect maintenance mode to be available with the route stack. The Route package now declares the supporting cache, config, hash, and storage dependencies, and the default command list follows Route availability instead of unrelated facade combinations.
Before this fix, apps without all maintenance dependencies could see requests aborted by the maintenance middleware or
down --secretfail on a nil hash service. After this fix, requests continue when maintenance mode cannot be supported, and secret generation reports the missing Hash facade as a command error.