test: add regression coverage for full generator import paths#1483
Open
u-wlkjyy wants to merge 1 commit into
Open
test: add regression coverage for full generator import paths#1483u-wlkjyy wants to merge 1 commit into
u-wlkjyy wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.17.x #1483 +/- ##
==========================================
Coverage ? 68.69%
==========================================
Files ? 281
Lines ? 17766
Branches ? 0
==========================================
Hits ? 12205
Misses ? 5056
Partials ? 505 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#973
The import-path bug is real on framework v1.17.2, but the underlying fix is already present on the v1.17.x branch. This PR adds regression coverage around the affected generators so CI catches any reintroduction:
✅ Checks