feat: test OTLP exporter TLS end to end#119
Open
krishankumar01 wants to merge 5 commits into
Open
Conversation
Add tls ca/cert/key knobs to the trace, metric, and log OTLP exporters, mirroring the framework stub, so the example can target a TLS-enabled collector (https:// endpoint with insecure=false).
There was a problem hiding this comment.
Pull request overview
This PR extends the example app’s telemetry configuration to allow OTLP trace/metric/log exporters to be configured for TLS by adding tls (ca/cert/key) file-path knobs in config/telemetry.go, aligning the example’s config surface with the framework’s expected options while keeping default plaintext behavior unchanged.
Changes:
- Add
tlsmap support to the OTLP trace exporter configuration (CA + optional mTLS client cert/key). - Add
tlsmap support to the OTLP metric exporter configuration (CA + optional mTLS client cert/key). - Add
tlsmap support to the OTLP log exporter configuration (CA + optional mTLS client cert/key).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+198
to
+199
| // TLS certificate file paths. Set "ca" and use an https:// endpoint | ||
| // with insecure=false to reach a TLS-enabled collector. |
Comment on lines
+227
to
+228
| // TLS certificate file paths. Set "ca" and use an https:// endpoint | ||
| // with insecure=false to reach a TLS-enabled collector. |
Comment on lines
+251
to
+252
| // TLS certificate file paths. Set "ca" and use an https:// endpoint | ||
| // with insecure=false to reach a TLS-enabled collector. |
…th framework master
krishankumar01
changed the title
Comment on lines
+14
to
+23
| otel-collector-tls: | ||
| image: otel/opentelemetry-collector-contrib:latest | ||
| restart: always | ||
| command: ["--config=/etc/otel-config-tls.yaml"] | ||
| volumes: | ||
| - ./otel-config-tls.yaml:/etc/otel-config-tls.yaml | ||
| - ./tests/testdata/otel-tls:/etc/otel-tls:ro | ||
| ports: | ||
| - "4319:4319" | ||
|
|
krishankumar01
changed the title
Comment on lines
+46
to
+47
| s.False(facades.Process().Path("../../").Run("docker compose up -d prometheus jaeger loki otel-collector-tls").Failed()) | ||
| time.Sleep(5 * time.Second) |
Comment on lines
+85
to
+88
| s.NoError(facades.App().Restart()) | ||
|
|
||
| s.False(facades.Process().Path("../../").Run("docker compose down").Failed()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Tests the OTLP exporter TLS config from goravel/framework#1475 end to end.
otel-collector-tlscompose service: OTLP over TLS on:4319, exporting to the same Jaeger/Prometheus/Loki backends as the existing collector.TestTelemetryTLSTestSuitegenerates a CA and server certificate at setup, points the exporters athttps://localhost:4319/v1/<signal>withinsecure=falseandtls.ca, and asserts traces, metrics, and logs arrive.config/telemetry.gowithpackage:install Telemetryand pins the framework to current master, which also fixes theTestInstallAndUninstall*failures on master CI.✅ Checks