Skip to content

Harness checks: real Loop work, teardowns, duplicate and per-job checks; full rerun - #6

Merged
fahimfaisaal merged 4 commits into
mainfrom
fix/harness-checks
Oct 25, 2026
Merged

fahimfaisaal merged 4 commits into
mainfrom
fix/harness-checks

Conversation

@fahimfaisaal

Copy link
Copy Markdown
Member

What

Fixes the harness gaps the README audit found, reruns every suite, and updates the READMEs from the new data.

  • pool
    • The Loop10 and Loop10K tasks keep their sum, so the compiler runs the arithmetic instead of deleting it. Loop10K is now about 3 µs of real work per task, up from about 1 µs of empty loop.
    • Ants' teardown is ReleaseTimeout(time.Minute), which waits for its workers to exit.
    • VarMQ's teardown adds WaitUntilStopped after WaitAndStop. That returns once every worker has been sent a stop. varmq has no API that waits for its worker goroutines to exit, so the README says VarMQ and Gopool (no teardown at all) still skip that wait.
  • redis
    • A Durable row fails on any duplicate delivery, counted after every instance has stopped.
    • The latency run fails on a delivery of any job other than the one just enqueued.
  • sqlite
    • Every job has an id unique across queues, and a shared per-job tally fails a row on a duplicate, an unknown id or a job never handled.
    • The tally is checked after the last job and again after close.
  • Rerun 2026-10-25: pool 1,485 rows (24, 8 and 4 CPUs), redis 150, sqlite 32, all -benchtime=2x. No row failed, so no library delivered a job twice and every sqlite job ran exactly once.

Verified

  • go vet clean in all three modules, and TestSubjects passes in sqlite and redis.
  • task site:json builds 495 ×3, 135 and 32 rows.
  • A reviewer recomputed every README number from the new txt files and checked each harness claim against the code.

🤖 Generated with Claude Code

fahimfaisaal and others added 4 commits October 25, 2026 12:27
- pool: the Loop tasks keep their sum, so the compiler can no longer
  delete the arithmetic and leave an empty counted loop. Ants' teardown
  waits for its workers to exit (ReleaseTimeout), like every other
  subject that has a teardown; Gopool still has none.
- redis: a Durable row fails on any duplicate delivery, counted after
  every consumer has stopped; the latency run fails on a delivery of any
  job other than the one just enqueued.
- sqlite: every job gets an id unique across queues and a shared tally
  fails a row on a duplicate, an unknown id or a job never seen, checked
  again after close.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WaitAndStop returns once no job is queued or running and only signals
the workers to stop. WaitUntilStopped waits for the event loop to stop
every worker, which matches the subjects whose teardown joins theirs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pool 1,485 rows (24, 8 and 4 CPUs), redis 150, sqlite 32, all -benchtime=2x
on varmq v1.10.0 (local checkout through replace). No row failed: no
duplicate deliveries in redis, every sqlite job handled exactly once.
The pool Loop rows now include real arithmetic, and Ants and VarMQ
teardowns wait for their workers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Numbers regenerated from the 2026-10-25 rerun. The gap notes are gone
where the harness now closes them: Loop tasks do real arithmetic, Ants
waits for its workers, redis rows fail on duplicates and stray latency
deliveries, sqlite tracks every job id. Two teardowns still return
before their workers exit and say so: Gopool has none, and varmq's
WaitUntilStopped returns once every worker has been sent a stop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fahimfaisaal
fahimfaisaal merged commit d1eaf4d into main Oct 25, 2026
1 check passed
@fahimfaisaal
fahimfaisaal deleted the fix/harness-checks branch October 25, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant