Repository navigation
fix(site): stable sqlite series order, stack every chart - #2
Merged
Merged
Conversation
vizb orders a chart's series by the first y value seen in the whole dataset but leaves each series' values in the group's own order, so the Mixed10Q chart labelled the Folder bars SingleFile. The scenario now emits SingleFile first, with a rerun of bench/sqlite.txt and an updated Results table. The redis and sqlite conversions pass --stack like pool, so every dataset starts stacked. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ts note Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two chart fixes.
finalizeChartreorders a chart's y values to the dataset-wide first-seen order but keeps each series' values in the group's own order (ui/src/lib/builders/finalize.ts, theapplyCanonicalOrder(yAxisValues, canonical.y)line). Until that is fixed upstream, the sqlite scenario emits SingleFile first so both orders agree.bench/sqlite.txtis rerun (numbers moved up to 2x on ckpt10000 rows, same machine, an hour apart) and the Results table follows it.--stacklike the pool ones, so all six datasets start stacked.🤖 Generated with Claude Code