Skip to content

fix(cl): normalize C/C++ documentation comment markers - #931

Closed
xushiwei with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-comments-format-bug
Closed

xushiwei with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-comments-format-bug

Conversation

Copilot AI commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Comment extraction could leak decorative asterisks from block-comment delimiters into generated Go docs, and retain the ! marker from /*! ... */ comments.

  • Formatting: Strip bang-style markers and discard lines containing only delimiter asterisks.
  • Coverage: Add regression cases for Python-style banner comments and standard C/C++ block and line comments.
/**********
Documentation text.
**********/

The generated Go doc comment contains only // Documentation text..

Copilot AI linked an issue Oct 5, 2026 that may be closed by this pull request
Co-authored-by: xushiwei <396972+xushiwei@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix comments format bug for Clang and Python documentation fix(cl): normalize C/C++ documentation comment markers Oct 5, 2026
Copilot AI requested a review from xushiwei October 5, 2026 12:34
@xushiwei

xushiwei commented Oct 5, 2026

Copy link
Copy Markdown
Member

@copilot The issue hasn't been resolved; CI on the Mac platform is still failing.

Co-authored-by: xushiwei <396972+xushiwei@users.noreply.github.com>

Copilot AI commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@copilot The issue hasn't been resolved; CI on the Mac platform is still failing.

The macOS failure came from enabling -fparse-all-comments for every config, which changed LLVM goldens. It is now opt-in via KeepDoc and enabled for Python; the LLVM system and Python golden tests pass locally. Fixed in 01e886a.

Co-authored-by: xushiwei <396972+xushiwei@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cl): comments format bugfix

2 participants