Skip to content

refactor: enhance regression test - #708

Open
noahchoii wants to merge 13 commits into
data-slotsfrom
enhance-regression
Open

refactor: enhance regression test#708
noahchoii wants to merge 13 commits into
data-slotsfrom
enhance-regression

Conversation

@noahchoii

Copy link
Copy Markdown
Contributor

Description of Changes

@coderabbitai summary

  • composites 패키지의 Dialog 회귀 테스트를 추가했습니다.
  • Playwright 회귀 테스트가 core, composites 패키지에 중복으로 존재하기 때문에 파이프라인 관리 및 유지보수가 어려워 질 수 있습니다. 따라서 Playwright 코드를 Storybook 패키지로 이관했습니다. 기존에도 VRT는 스토리북 빌드 파일을 사용하고 있기 때문에, 응집성 측면에서 오히려 더 개선되었다고 볼 수도 있을 거 같아요.
  • 회귀 테스트의 스토리베드를 추가할 때 사용할 AI Skills를 추가해두었습니다. /add-composites-test-bed 커맨드로 사용할 수 있습니다. 사용하면 시각적 회귀 테스트에 포함되어야 할 축을 직접 결정하고, Light, Dark 모드에 대한 테스트베드를 각각 추가합니다. 그리고 마지막으로 축 결정 기준을 알려줍니다. UI는 매번 새로 생성하지 않도록 유틸리티 컴포넌트를 만들어두었어요. dialog와 alert-dialog를 대상으로 테스트 해봤는데, 아직까지는 크게 예외적인 케이스가 없어서 무난하게 만들어주지만 점검을 꾸준히 해봐야 할 것 같구요, 다른 컴포넌트에도 계속해서 테스트해보면서 다듬어보면 좋을 것 같아요.

Checklist

Before submitting the PR, please make sure you have checked all of the following items.

  • The PR title follows the Conventional Commits convention. (e.g., feat, fix, docs, style, refactor, test, chore)
  • I have added tests for my changes.
  • I have updated the Storybook or relevant documentation.
  • I have added a changeset for this change. (e.g., for any changes that affect users, such as component prop changes or new features).
  • I have performed a self-code review.
  • I have followed the project's coding conventions and component patterns.

@noahchoii
noahchoii requested a review from MaxLee-dev as a code owner August 27, 2026 13:38
@changeset-bot

changeset-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5e077b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vapor-ui Ready Ready Preview Aug 27, 2026 1:38pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fb2e3b29-fcec-48de-add8-cfa6b15f135e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vapor-ui

Copy link
Copy Markdown
Collaborator

All tests passed!

Tests Passed Failed Duration Report
176 176 0 1m 22s Open report ↗︎

Click here if you need to update snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants