fix(core): align surface components with canvas token hierarchy - #698
fix(core): align surface components with canvas token hierarchy#698MaxLee-dev wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 265dc85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough캔버스 색상 토큰 계층을 조정하고 Changes캔버스 배경 토큰 정비
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR aligns surface component backgrounds and overlays with the canvas token hierarchy and exposes the missing inverse-canvas sprinkle mapping. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ All tests passed!
Click here if you need to update snapshots. |
6abb501 to
d3a01e5
Compare
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@vapor-ui/core': minor | |||
There was a problem hiding this comment.
새 기능이 추가된 게 아니라 기존 토큰의 변경이라서 patch 버전 업데이트가 적절해 보이는데, 어떻게 생각하시나요??
There was a problem hiding this comment.
는 sprinkles에 추가된 게 맞으니 minor가 맞겠네요..!
Related Issues
canvas-inverse추가Description of Changes
Summary by CodeRabbit
스타일
새 기능
bg-canvas-inverse배경색 유틸리티가 추가되었습니다.canvas-inverse가 들어오면서 tooltip과 toast는 canvas 계열로 옮겨졌지만, 남은 표면 컴포넌트는 여전히 위계와 맞지 않는 토큰이나 raw 값을 쓰고 있었습니다. 이번 PR에서 그 나머지를 맞췄습니다.컴포넌트
background.canvas-overlaybackground.canvas-basecolor.gray.100background.secondarycolor.blackbackground.canvas-dimrgba(0, 0, 0, 32%)background.canvas-dim+opacity: 0.32sheet 오버레이는 dialog와 같은 방식(
canvas-dim+opacity)으로 통일했습니다.토큰
canvas-100/canvas-200을gray-050/gray-025로 조정했습니다. 각각canvas-base/canvas-sunken과 값이 어긋나 있어 V1 별칭을 쓰는 쪽과 V2를 쓰는 쪽의 배경이 달라지던 문제입니다.bg-canvas-inverse를 노출했습니다. VAPOR-252에서 토큰만 추가되고 sprinkles 매핑이 빠져 있었습니다.Screenshots
Checklist
Before submitting the PR, please make sure you have checked all of the following items.