Skip to content

chore: add code connect for Dialog - #687

Open
noahchoii wants to merge 7 commits into
new-composites-packagefrom
dialog-code-connect
Open

chore: add code connect for Dialog#687
noahchoii wants to merge 7 commits into
new-composites-packagefrom
dialog-code-connect

Conversation

@noahchoii

Copy link
Copy Markdown
Contributor

Description of Changes

@coderabbitai summary

  • @vapor-ui/composites 패키지의 Dialog에 코드 커넥트를 연결했습니다.
  • Variants 기반으로 자동 추출을 목표로 했으나, 아직까지는 컴포넌트가 하나라 명확한 정책을 결정하기 어려운 단계라고 판단했습니다. 따라서 새 컴포넌트를 추가하면서 공통되는 규칙을 잘 기록해두고, 이를 바탕으로 나중에 따로 추출 로직을 작성하겠습니다.

Screenshots

Checklist

Before submitting the PR, please make sure you have checked all of the following items.

  • The PR title follows the Conventional Commits convention. (e.g., feat, fix, docs, style, refactor, test, chore)
  • I have added tests for my changes.
  • I have updated the Storybook or relevant documentation.
  • I have added a changeset for this change. (e.g., for any changes that affect users, such as component prop changes or new features).
  • I have performed a self-code review.
  • I have followed the project's coding conventions and component patterns.

@noahchoii
noahchoii requested a review from MaxLee-dev as a code owner August 19, 2026 14:11
@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vapor-ui Ready Ready Preview Aug 28, 2026 2:10am

Request Review

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 28ef1b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 63fb61a6-c937-4d12-9918-72eec5d4b5c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@noahchoii noahchoii changed the title Dialog code connect feat: add code connect for Dialog Aug 19, 2026
@noahchoii noahchoii changed the title feat: add code connect for Dialog chore: add code connect for Dialog Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant