fix: Support client-side result limiting (max_results) for ListSkills and ListSkillRevisions in Python SDK

agentplatform/_genai/skill_revisions.py

@@ -15,6 +15,7 @@
 
 # Code generated by the Google Gen AI SDK generator DO NOT EDIT.
 
+from functools import partial
 import json
 import logging
 from typing import Any, Optional, Union
@@ -24,6 +25,7 @@
 from google.genai import _common
 from google.genai._common import get_value_by_path as getv
 from google.genai._common import set_value_by_path as setv
+from google.genai.pagers import AsyncPager, Pager
 
 from . import types
 
@@ -151,16 +153,12 @@ def get(
         self._api_client._verify_response(return_value)
         return return_value
 
-    def list(
+    def _list(
         self,
         *,
         name: str,
         config: Optional[types.ListSkillRevisionsConfigOrDict] = None,
     ) -> types.ListSkillRevisionsResponse:
-        """
-        Lists Skill Revisions.
-        """
-
         parameter_model = types._ListSkillRevisionsRequestParameters(
             name=name,
             config=config,
@@ -225,6 +223,24 @@ def list(
         self._api_client._verify_response(return_value)
         return return_value
 
+    def list(
+        self,
+        *,
+        name: str,
+        config: Optional[types.ListSkillRevisionsConfigOrDict] = None,
+    ) -> Pager[types.SkillRevision]:
+        """
+        Lists Skill Revisions.
+        """
+
+        list_request = partial(self._list, name=name)
+        return Pager(
+            "skill_revisions",
+            list_request,
+            self._list(name=name, config=config),
+            config,
+        )
+
 
 class AsyncSkillRevisions(_api_module.BaseModule):
     """Class for managing Skill Revisions in the Skill Registry."""
@@ -300,16 +316,12 @@ async def get(
         self._api_client._verify_response(return_value)
         return return_value
 
-    async def list(
+    async def _list(
         self,
         *,
         name: str,
         config: Optional[types.ListSkillRevisionsConfigOrDict] = None,
     ) -> types.ListSkillRevisionsResponse:
-        """
-        Lists Skill Revisions.
-        """
-
         parameter_model = types._ListSkillRevisionsRequestParameters(
             name=name,
             config=config,
@@ -375,3 +387,17 @@ async def list(
 
         self._api_client._verify_response(return_value)
         return return_value
+
+    async def list(
+        self,
+        *,
+        name: str,
+        config: Optional[types.ListSkillRevisionsConfigOrDict] = None,
+    ) -> AsyncPager[types.SkillRevision]:
+        list_request = partial(self._list, name=name)
+        return AsyncPager(
+            "skill_revisions",
+            list_request,
+            await self._list(name=name, config=config),
+            config,
+        )

agentplatform/_genai/types/common.py

@@ -18468,6 +18468,10 @@ class ListSkillsConfig(_common.BaseModel):
     filter: Optional[str] = Field(
         default=None, description="""Optional. The standard list filter."""
     )
+    max_results: Optional[int] = Field(
+        default=None,
+        description="""Optional. Maximum number of results to return. Defaults to 100.""",
+    )
 
 
 class ListSkillsConfigDict(TypedDict, total=False):
@@ -18485,6 +18489,9 @@ class ListSkillsConfigDict(TypedDict, total=False):
     filter: Optional[str]
     """Optional. The standard list filter."""
 
+    max_results: Optional[int]
+    """Optional. Maximum number of results to return. Defaults to 100."""
+
 
 ListSkillsConfigOrDict = Union[ListSkillsConfig, ListSkillsConfigDict]
 
@@ -18752,6 +18759,10 @@ class ListSkillRevisionsConfig(_common.BaseModel):
     )
     page_size: Optional[int] = Field(default=None, description="""""")
     page_token: Optional[str] = Field(default=None, description="""""")
+    max_results: Optional[int] = Field(
+        default=None,
+        description="""Optional. Maximum number of results to return. Defaults to 100.""",
+    )
 
 
 class ListSkillRevisionsConfigDict(TypedDict, total=False):
@@ -18765,6 +18776,9 @@ class ListSkillRevisionsConfigDict(TypedDict, total=False):
     page_token: Optional[str]
     """"""
 
+    max_results: Optional[int]
+    """Optional. Maximum number of results to return. Defaults to 100."""
+
 
 ListSkillRevisionsConfigOrDict = Union[
     ListSkillRevisionsConfig, ListSkillRevisionsConfigDict

tests/unit/agentplatform/genai/replays/test_skills_revisions_list.py

@@ -40,8 +40,8 @@ def test_list_skill_revisions(client, tmp_path):
         assert created_skill.name is not None
 
         # 2. List revisions
-        revisions_response = client.skills.revisions.list(name=created_skill.name)
-        revisions_list = revisions_response.skill_revisions
+        pager = client.skills.revisions.list(name=created_skill.name)
+        revisions_list = list(pager)
 
         assert len(revisions_list) > 0
         first_revision = revisions_list[0]