chore(storage): remove TODO on checksum validation on reopen - #6751
Merged
vsharonlynn merged 1 commit intoSep 10, 2026
Merged
Conversation
Removes TODO(googleapis#5716) in transport.rs. `persisted_data_checksums` is optional in the GCS v2 API, and the backend may omit it on reopen (e.g. emulator mocks). The client already handles this by falling back to `running_crc32c = None` (verified by `reopen_server_does_not_return_checksum`), so the TODO is resolved.
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a TODO comment in src/storage/src/storage/bidi_write/transport.rs regarding whether a missing checksum is valid when persisted_size is greater than zero. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6751 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 319 319
Lines 105574 105574
=======================================
+ Hits 102365 102368 +3
+ Misses 3209 3206 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes TODO(#5716) in transport.rs.
persisted_data_checksumsis optional in the GCS v2 API, and the backend may omit it on reopen (e.g. emulator mocks).The client already handles this by falling back to
running_crc32c = None(verified byreopen_server_does_not_return_checksum), so the TODO is resolved.