Skip to content

refactor(generated): regenerate crates with first-class convert module - #6747

Draft
suzmue wants to merge 1 commit into
googleapis:mainfrom
suzmue:convert-module-cleanup
Draft

refactor(generated): regenerate crates with first-class convert module#6747
suzmue wants to merge 1 commit into
googleapis:mainfrom
suzmue:convert-module-cleanup

Conversation

@suzmue

@suzmue suzmue commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Convert.rs is now discoverable and is formatted.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the generated code for multiple Google Cloud services (AI Platform, Apigee Connect, BigLake, CES, Data Catalog Lineage, Device Streaming, Dialogflow CX, Dialogflow v2, Discovery Engine, Gemini Data Analytics, Model Armor, Retail, Speech, Text-to-Speech, Vision AI, Logging, Maps Routes, Maps Routing, and Showcase). The changes primarily involve moving the convert.rs module inclusion from prost/includes.rs to the main lib.rs file, wrapped in appropriate feature gates where necessary, and improving the formatting of generated code (e.g., better line breaks in ToProto and FromProto implementations). No functional logic changes were identified.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.95%. Comparing base (cf0f036) to head (fb541d8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6747   +/-   ##
=======================================
  Coverage   96.94%   96.95%           
=======================================
  Files         316      316           
  Lines      105211   105211           
=======================================
+ Hits       101999   102005    +6     
+ Misses       3212     3206    -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant