feat(storage): make GrpcRustClient available to Storage GAPIC methods - #6745
Draft
joshuatants wants to merge 2 commits into
Draft
feat(storage): make GrpcRustClient available to Storage GAPIC methods#6745joshuatants wants to merge 2 commits into
joshuatants wants to merge 2 commits into
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the generator in librarian.yaml to use a custom gRPC client (crate::storage::bidi::GrpcClient) instead of the default gaxi::grpc::Client for the Rust storage library. Consequently, the generated transport files for both gapic and gapic_control have been updated to use this custom client in the StorageControl struct and its initialization. There are no review comments, and I have no feedback to provide.
joshuatants
force-pushed
the
grpc_rust_enable_for_unary
branch
from
September 9, 2026 00:09
9e3cb16 to
bae987d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## grpc_rust #6745 +/- ##
=============================================
- Coverage 96.96% 96.95% -0.01%
=============================================
Files 322 322
Lines 107029 107029
=============================================
- Hits 103783 103774 -9
- Misses 3246 3255 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshuatants
force-pushed
the
grpc_rust_enable_for_unary
branch
2 times, most recently
from
September 9, 2026 00:40
aefabf0 to
cd04070
Compare
vsharonlynn
approved these changes
Sep 9, 2026
xlai20
requested changes
Sep 9, 2026
Configure `grpc_client: crate::storage::bidi::GrpcClient` specifically for `google-cloud-storage` in librarian.yaml and regenerate the GAPIC transports. This makes `GrpcRustClient` available exclusively to Storage's GAPIC transports under `--cfg google_cloud_unstable_grpc_rust`, while defaulting to `gaxi::grpc::Client` (Tonic) when the flag is absent.
joshuatants
force-pushed
the
grpc_rust_enable_for_unary
branch
from
September 9, 2026 03:26
cd04070 to
3f4f626
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure
grpc_client: crate::storage::bidi::GrpcClientspecifically forgoogle-cloud-storagein librarian.yaml and regenerate the GAPIC transports.This makes
GrpcRustClientavailable exclusively to Storage's GAPIC transports under--cfg google_cloud_unstable_grpc_rust, while defaulting togaxi::grpc::Client(Tonic) when the flag is absent.For #5991.