Skip to content

chore(spanner): add configuration builders for dynamic channel pool - #6736

Open
olavloite wants to merge 1 commit into
googleapis:mainfrom
olavloite:spanner-dynamic-channel-pool-config
Open

chore(spanner): add configuration builders for dynamic channel pool#6736
olavloite wants to merge 1 commit into
googleapis:mainfrom
olavloite:spanner-dynamic-channel-pool-config

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

Adds fluent builder methods and constructor helpers for DynamicChannelPoolConfig and StaticChannelPoolConfig.

This provides a builder API to customize channel pool settings, such as initial/min/max channel bounds, scale-up and scale-down thresholds, error penalty parameters, and channel selection strategies.

@olavloite
olavloite requested review from a team as code owners September 8, 2026 14:47
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label Sep 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation examples, builder methods, and tests for the static and dynamic channel pool configurations in the Spanner client, while marking several configuration structs and enums as #[non_exhaustive]. The review feedback suggests keeping the static_config helper method in the main module gated by #[cfg(test)] rather than moving its implementation entirely into the test module, which improves code discoverability and centralization.

Comment thread src/spanner/src/channel_pool/config.rs
Comment thread src/spanner/src/channel_pool/config.rs Outdated
@olavloite
olavloite force-pushed the spanner-dynamic-channel-pool-config branch from ab50c48 to b69720b Compare September 8, 2026 15:03
@olavloite

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation examples, #[non_exhaustive] attributes, and builder/constructor methods for the Spanner channel pool configurations, along with corresponding unit tests. The feedback suggests replacing the fluent builder methods on the configuration structs with standard setter methods to maintain API consistency across the repository.

Comment thread src/spanner/src/channel_pool/config.rs
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.95%. Comparing base (4afc819) to head (b69720b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6736    +/-   ##
========================================
  Coverage   96.95%   96.95%            
========================================
  Files         313      313            
  Lines      105118   105234   +116     
========================================
+ Hits       101916   102031   +115     
- Misses       3202     3203     +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olavloite
olavloite requested a review from rahul2393 September 8, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant