chore(spanner): add configuration builders for dynamic channel pool - #6736
chore(spanner): add configuration builders for dynamic channel pool#6736olavloite wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds documentation examples, builder methods, and tests for the static and dynamic channel pool configurations in the Spanner client, while marking several configuration structs and enums as #[non_exhaustive]. The review feedback suggests keeping the static_config helper method in the main module gated by #[cfg(test)] rather than moving its implementation entirely into the test module, which improves code discoverability and centralization.
ab50c48 to
b69720b
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds documentation examples, #[non_exhaustive] attributes, and builder/constructor methods for the Spanner channel pool configurations, along with corresponding unit tests. The feedback suggests replacing the fluent builder methods on the configuration structs with standard setter methods to maintain API consistency across the repository.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6736 +/- ##
========================================
Coverage 96.95% 96.95%
========================================
Files 313 313
Lines 105118 105234 +116
========================================
+ Hits 101916 102031 +115
- Misses 3202 3203 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds fluent builder methods and constructor helpers for
DynamicChannelPoolConfigandStaticChannelPoolConfig.This provides a builder API to customize channel pool settings, such as initial/min/max channel bounds, scale-up and scale-down thresholds, error penalty parameters, and channel selection strategies.