Skip to content

docs(storage): add sample for open appendable object send_and_append - #6491

Merged
vsharonlynn merged 1 commit into
googleapis:mainfrom
vsharonlynn:send-and-append
Sep 10, 2026
Merged

docs(storage): add sample for open appendable object send_and_append#6491
vsharonlynn merged 1 commit into
googleapis:mainfrom
vsharonlynn:send-and-append

Conversation

@vsharonlynn

@vsharonlynn vsharonlynn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Issue #5716 .

This PR follows PR #6490 .

@product-auto-label product-auto-label Bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Aug 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the send_and_append feature for the open_appendable_object API in the Google Cloud Storage Rust SDK, allowing clients to send an initial chunk of data directly within the opening stream request. The changes update the AppendObjectSpecState enum to track the initial payload, add a new connect_open_and_append method in the connector, and implement support in AppendableObjectWriterTransport to handle and potentially split the initial chunk. A new example and corresponding unit tests have also been added to verify the functionality. I have no feedback to provide as there are no review comments.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (b368afc) to head (b76a64f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6491   +/-   ##
=======================================
  Coverage   96.97%   96.98%           
=======================================
  Files         325      325           
  Lines      106402   106402           
=======================================
+ Hits       103188   103194    +6     
+ Misses       3214     3208    -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vsharonlynn
vsharonlynn force-pushed the send-and-append branch 3 times, most recently from 7a5dcda to d438320 Compare August 31, 2026 03:10
@vsharonlynn
vsharonlynn marked this pull request as ready for review August 31, 2026 03:10
@vsharonlynn
vsharonlynn requested review from a team as code owners August 31, 2026 03:10
@vsharonlynn

Copy link
Copy Markdown
Contributor Author

gcb rust-sdk-testing is crashing with:

thread 'tests::object_examples' (85415) has overflowed its stack
fatal runtime error: stack overflow, aborting

I sent out a PR to prevent this storage-sample stack overflow: #6660 .
Will revisit this PR after #6660 is merged.

@vsharonlynn
vsharonlynn enabled auto-merge (squash) September 10, 2026 17:14
@vsharonlynn
vsharonlynn merged commit 2c6bc65 into googleapis:main Sep 10, 2026
42 checks passed
@vsharonlynn
vsharonlynn deleted the send-and-append branch September 11, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants