refactor(gax): extract transport policies to grpc_helpers#6024
refactor(gax): extract transport policies to grpc_helpers#6024joshuatants wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Client struct to consolidate retry, backoff, and timeout policies into a new TransportPolicies struct, improving maintainability. It also introduces this struct in grpc_helpers.rs along with comprehensive tests. The reviewer suggested replacing .unwrap() calls with .expect() in the new tests to better align with the repository's style guide for error handling in test code.
joshuatants
force-pushed
the
grpc-rust-helpers-extraction
branch
from
e192391 to
4c6f202
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6024 +/- ##
==========================================
+ Coverage 97.08% 97.09% +0.01%
==========================================
Files 244 244
Lines 61351 61488 +137
==========================================
+ Hits 59560 59703 +143
+ Misses 1791 1785 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| Ok(headers) | ||
| } | ||
|
|
||
| /// Policies governing gRPC client transport behaviors. |
There was a problem hiding this comment.
Consider a separate module for this... Generic "helper" or "utils" modules tend to get bloated over time, better to fight the problem as early as possible.
2 participants
No description provided.