feat(gax): introduce GrpcRustClient skeleton#5999
Merged
joshuatants merged 2 commits intoJul 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new, conditionally compiled grpc_rust module containing stubs for GrpcRustClient and GrpcRustStreaming under the google_cloud_unstable_grpc_rust configuration. The feedback suggests renaming the getter methods get_polling_error_policy and get_polling_backoff_policy to omit the get_ prefix, aligning with Rust naming conventions and the repository style guide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5999 +/- ##
==========================================
- Coverage 97.73% 97.72% -0.01%
==========================================
Files 244 244
Lines 61161 61161
==========================================
- Hits 59776 59772 -4
- Misses 1385 1389 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ab8916c to
3f0287f
Compare
coryan
requested changes
Jul 8, 2026
013552c to
523a011
Compare
523a011 to
4a328e1
Compare
coryan
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5991.
Introducing a skeleton unblocks working on the changes needed for Storage for both the hand-written (#6000) and GAPIC (changes to be made to the relevant templates in
librarian) clients.