Repository navigation
fix(bigquery-magics): wait for graph server startup before returning from init - #18763
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a synchronization mechanism using threading.Event to ensure that GraphServer.init() blocks until the background TCP server is fully initialized, resolving a race condition with stop_server(). A unit test was also added to verify this behavior. The feedback suggests avoiding an indefinite wait on self._server_ready.wait() by implementing a polling mechanism with a timeout, which prevents the main thread from hanging if the background server thread fails to start (e.g., due to port binding errors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphServer.init()starts the server on a background thread and returns immediately. Ifstop_server()is called right afterinit()(for example, in fast unit tests that don't make HTTP requests),self._servermay still beNone. When that happens,stop_server()does nothing andserver_thread.join()hangs indefinitely inserve_forever().This PR adds a
threading.Eventsoinit()waits untilself._serveris assigned before returning.