Skip to content

chore(tests): break up sqlalchemy system tests #18239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-sanche wants to merge 4 commits into
base: main
Choose a base branch
from
+21 −2
Open

chore(tests): break up sqlalchemy system tests #18239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f208aef
chore: split sqlalchemy system tests into separate check
daniel-sanche Aug 27, 2026
2649a9a
Update .kokoro/system.sh
daniel-sanche Aug 27, 2026
e54cad5
applied minor fixes to relevant packages
daniel-sanche Aug 27, 2026
8c596bd
chore: trigger build
daniel-sanche Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .kokoro/presubmit/sqlalchemy_compliance.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Format: //devtools/kokoro/config/proto/build.proto

# Only run compliance nox session.
env_vars: {
key: "NOX_SESSION"
value: "compliance"
}
Comment thread
daniel-sanche marked this conversation as resolved.
6 changes: 6 additions & 0 deletions .kokoro/presubmit/system.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@ env_vars: {
key: "NOX_SESSION"
value: "system-3.12"
}

# Skip compliance tests in system job since they run in dedicated compliance job
env_vars: {
key: "RUN_COMPLIANCE_TESTS"
value: "false"
}
6 changes: 6 additions & 0 deletions .kokoro/system.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,12 @@ for path in `find 'packages' \
files_to_check=("${package_path}")
fi

# When running compliance tests, only test packages that have compliance suites
if [[ "${NOX_SESSION:-}" == "compliance"* && "${package_name:-}" != "sqlalchemy-"* ]]; then
printf "SKIP %-20s %-40s %s\n" "[not_applicable]" "${package_name}" "${commit_hash:-HEAD}"
continue
fi

set +e
# Passing the array expanded as arguments to git diff.
package_modified=$(git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- "${files_to_check[@]}" | wc -l)
Expand Down
2 changes: 1 addition & 1 deletion packages/sqlalchemy-bigquery/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ SQLAlchemy Dialect for BigQuery

|GA| |pypi| |versions|

`SQLALchemy Dialects`_
`SQLAlchemy Dialects`_

@daniel-sanche daniel-sanche Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked Gemini to find typos to fix to trigger the tests, instead of adding a temporary change. It found a couple!


- `Dialect Documentation`_
- `Product Documentation`_
Expand Down
2 changes: 1 addition & 1 deletion packages/sqlalchemy-spanner/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Spanner dialect for SQLAlchemy
Spanner dialect for SQLAlchemy represents an interface API designed to
make it possible to control Cloud Spanner databases with SQLAlchemy API.
The dialect is built on top of `the Spanner DB
API <https://github.com/googleapis/python-spanner/tree/master/google/cloud/spanner_dbapi>`__,
API <https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-spanner/google/cloud/spanner_dbapi>`__,
which is designed in accordance with
`PEP-249 <https://www.python.org/dev/peps/pep-0249/>`__.

Expand Down
Loading