Skip to content

chore: address pandas 3 failure and remove inherently flaky system test#17452

Merged
tswast merged 2 commits into
mainfrom
b523301714-pandas-tests
Jun 12, 2026
Merged

chore: address pandas 3 failure and remove inherently flaky system test#17452
tswast merged 2 commits into
mainfrom
b523301714-pandas-tests

Conversation

@tswast

@tswast tswast commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Fixes b/523301714 🦕

@tswast tswast requested review from a team as code owners June 12, 2026 18:29
@tswast tswast requested review from sycai and removed request for a team June 12, 2026 18:29

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up imports and removes a timeout query test in test_query.py, and updates a pandas system test assertion to allow alternative string column dtype names. A review comment correctly points out that the nullable string data type in pandas is named "string" rather than "str", and suggests updating the assertion to check for "string" or "object".

Comment thread packages/google-cloud-bigquery/tests/system/test_pandas.py Outdated
@tswast tswast merged commit dd59d36 into main Jun 12, 2026
32 checks passed
@tswast tswast deleted the b523301714-pandas-tests branch June 12, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants