Skip to content

chore(handwritten): centralize mypy configuration and update handwritten package noxfiles #17409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chalmerlowe wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore(handwritten): centralize mypy configuration and update handwritten package noxfiles #17409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91a6167
feat: centralize mypy config
chalmerlowe Jun 9, 2026
1afd309
feat(handwritten): centralize mypy.ini and update noxfiles
chalmerlowe Jun 9, 2026
8dd9661
style(mypy): format modified noxfile.py files with black
chalmerlowe Jun 9, 2026
4854f7e
Merge branch 'main' into feat/centralize-mypy-handwritten
chalmerlowe Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions packages/bigframes/mypy.ini
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/bigframes/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@
LOGGING_NAME_ENV_VAR = "BIGFRAMES_PERFORMANCE_LOG_NAME"

CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")


# Sessions are executed in the order so putting the smaller sessions
# ahead to fail fast at presubmit running.
Expand Down Expand Up @@ -1085,6 +1088,7 @@ def mypy(session):
shutil.rmtree(".mypy_cache", ignore_errors=True)
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"bigframes",
os.path.join("tests", "system"),
os.path.join("tests", "unit"),
Expand Down
3 changes: 0 additions & 3 deletions packages/bigquery-magics/mypy.ini
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/google-auth/mypy.ini
View file
Open in desktop

This file was deleted.

14 changes: 13 additions & 1 deletion packages/google-auth/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
import nox

CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")


CLICK_VERSION = "click"
BLACK_VERSION = "black==23.7.0"
Expand Down Expand Up @@ -156,7 +159,16 @@ def mypy(session):
"types-mock",
"pytest<8.0.0",
)
session.run("mypy", "-p", "google", "-p", "tests", "-p", "tests_async")
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"-p",
"google",
"-p",
"tests",
"-p",
"tests_async",
)


@nox.session(python=ALL_PYTHON)
Expand Down
15 changes: 0 additions & 15 deletions packages/google-backstory/mypy.ini
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/google-backstory/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
PREVIEW_PYTHON_VERSION = "3.14"

CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")


if (CURRENT_DIRECTORY / "testing").exists():
LOWER_BOUND_CONSTRAINTS_FILE = (
Expand Down Expand Up @@ -107,6 +110,7 @@ def mypy(session):
session.install(".")
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"-p",
"google",
"--check-untyped-defs",
Expand Down
15 changes: 0 additions & 15 deletions packages/google-cloud-appengine-logging/mypy.ini
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/google-cloud-appengine-logging/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
PREVIEW_PYTHON_VERSION = "3.14"

CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")


if (CURRENT_DIRECTORY / "testing").exists():
LOWER_BOUND_CONSTRAINTS_FILE = (
Expand Down Expand Up @@ -107,6 +110,7 @@ def mypy(session):
session.install(".")
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"-p",
"google",
"--check-untyped-defs",
Expand Down
15 changes: 0 additions & 15 deletions packages/google-cloud-bigquery-logging/mypy.ini
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/google-cloud-bigquery-logging/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
PREVIEW_PYTHON_VERSION = "3.14"

CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")


if (CURRENT_DIRECTORY / "testing").exists():
LOWER_BOUND_CONSTRAINTS_FILE = (
Expand Down Expand Up @@ -107,6 +110,7 @@ def mypy(session):
session.install(".")
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"-p",
"google",
"--check-untyped-defs",
Expand Down
15 changes: 0 additions & 15 deletions packages/google-cloud-common/mypy.ini
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/google-cloud-common/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
PREVIEW_PYTHON_VERSION = "3.14"

CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")


if (CURRENT_DIRECTORY / "testing").exists():
LOWER_BOUND_CONSTRAINTS_FILE = (
Expand Down Expand Up @@ -107,6 +110,7 @@ def mypy(session):
session.install(".")
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"-p",
"google",
"--check-untyped-defs",
Expand Down
7 changes: 0 additions & 7 deletions packages/google-cloud-core/mypy.ini
View file
Open in desktop

This file was deleted.

11 changes: 10 additions & 1 deletion packages/google-cloud-core/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
"3.14",
]
CURRENT_DIRECTORY = os.path.abspath(os.path.dirname(__file__))
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = os.path.join(os.path.dirname(os.path.dirname(CURRENT_DIRECTORY)), "mypy.ini")

# Error if a python version is missing
nox.options.error_on_missing_interpreters = True
Expand Down Expand Up @@ -62,7 +64,14 @@ def mypy(session):
"types-mock",
"types-protobuf!=4.24.0.20240106",
)
session.run("mypy", "-p", "google", "-p", "tests")
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"-p",
"google",
"-p",
"tests",
)


@nox.session(python=DEFAULT_PYTHON_VERSION)
Expand Down
15 changes: 0 additions & 15 deletions packages/google-cloud-iam-logging/mypy.ini
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/google-cloud-iam-logging/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
PREVIEW_PYTHON_VERSION = "3.14"

CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")


if (CURRENT_DIRECTORY / "testing").exists():
LOWER_BOUND_CONSTRAINTS_FILE = (
Expand Down Expand Up @@ -107,6 +110,7 @@ def mypy(session):
session.install(".")
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"-p",
"google",
"--check-untyped-defs",
Expand Down
15 changes: 0 additions & 15 deletions packages/google-cloud-source-context/mypy.ini
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/google-cloud-source-context/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
PREVIEW_PYTHON_VERSION = "3.14"

CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")


if (CURRENT_DIRECTORY / "testing").exists():
LOWER_BOUND_CONSTRAINTS_FILE = (
Expand Down Expand Up @@ -107,6 +110,7 @@ def mypy(session):
session.install(".")
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"-p",
"google",
"--check-untyped-defs",
Expand Down
15 changes: 0 additions & 15 deletions packages/google-cloud-spanner-dbapi-driver/mypy.ini
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/google-cloud-spanner-dbapi-driver/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@
PREVIEW_PYTHON_VERSION = "3.14"

CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")


LOWER_BOUND_CONSTRAINTS_FILE = CURRENT_DIRECTORY / "constraints.txt"
PACKAGE_NAME = "google-cloud-spanner-dbapi-driver"
Expand Down Expand Up @@ -115,6 +118,7 @@ def mypy(session):
session.install(".")
session.run(
"mypy",
f"--config-file={MYPY_CONFIG_FILE}",
"-p",
"google",
)
Expand Down
3 changes: 0 additions & 3 deletions packages/google-cloud-testutils/mypy.ini
View file
Open in desktop

This file was deleted.

6 changes: 5 additions & 1 deletion packages/google-cloud-testutils/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@
RUFF_VERSION = "ruff==0.14.14"
BLACK_PATHS = ["test_utils", "setup.py"]
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
# Path to the centralized mypy configuration file at the repository root.
MYPY_CONFIG_FILE = str(CURRENT_DIRECTORY.parent.parent / "mypy.ini")



@nox.session(python=DEFAULT_PYTHON_VERSION)
Expand Down Expand Up @@ -113,7 +116,8 @@ def mypy(session):
"types-mock",
"types-setuptools",
)
session.run("mypy", "test_utils/", "tests/")
session.run("mypy",
f"--config-file={MYPY_CONFIG_FILE}", "test_utils/", "tests/")


@nox.session(python=ALL_PYTHON)
Expand Down
3 changes: 0 additions & 3 deletions packages/google-crc32c/mypy.ini
View file
Open in desktop

This file was deleted.

Loading
Loading