Skip to content

fix(gapic-generator): remove lagging 3.9 refs #16924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chalmerlowe wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(gapic-generator): remove lagging 3.9 refs #16924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7840c1
fix(gapic-generator): remove Python 3.9 from unit tests
chalmerlowe May 4, 2026
0df644d
fix(ci): remove Python 3.9 case from run_single_test.sh
chalmerlowe May 4, 2026
911e662
chore: removing blank line.
chalmerlowe May 4, 2026
7e460dc
fix(ci): remove Python 3.9 from unittest matrix
chalmerlowe May 4, 2026
32e54a2
Merge branch 'main' into fix/remove-3.9-refs
chalmerlowe Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unittest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
python: ['3.9', '3.10', "3.11", "3.12", "3.13", "3.14"]
python: ['3.10', "3.11", "3.12", "3.13", "3.14"]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
9 changes: 0 additions & 9 deletions ci/run_single_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,6 @@ case ${TEST_TYPE} in
;;
unit)
case ${PY_VERSION} in
"3.9")
if nox --list-sessions | grep -q "unit-3.9"; then
nox -s unit-3.9
retval=$?
else
echo "Skipping unit-3.9 as it is not supported by this package."
retval=0
fi
;;
"3.10")
nox -s unit-3.10
retval=$?
Expand Down
4 changes: 1 addition & 3 deletions packages/gapic-generator/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
RUFF_EXCLUDES = "*golden*,*pb2.py,*pb2.pyi"

ALL_PYTHON = (
"3.9",
"3.10",
"3.11",
"3.12",
Expand All @@ -58,8 +57,7 @@
@nox.session(python=ALL_PYTHON)
def unit(session):
"""Run the unit test suite."""
if session.python == "3.9":
session.skip("Skipping Python 3.9 unit tests temporarily.")

session.install(
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2478):
# Temporarily pin coverage to 7.11.0
Expand Down
Loading