Skip to content

chore: complete migration of google-cloud-storage#16705

Merged
jskeet merged 1 commit into
googleapis:mainfrom
jskeet:generate-storage
Apr 21, 2026
Merged

chore: complete migration of google-cloud-storage#16705
jskeet merged 1 commit into
googleapis:mainfrom
jskeet:generate-storage

Conversation

@jskeet

@jskeet jskeet commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Removed skip_generate and regenerated with Librarian.

@jskeet jskeet requested review from a team as code owners April 17, 2026 05:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the configuration and metadata for the Google Cloud Storage library. Key changes include removing the skip_generate flag in librarian.yaml, reordering and cleaning up fields in .repo-metadata.json (specifically removing requires_billing and codeowner_team), and a minor comment update in noxfile.py. I have no feedback to provide.

@parthea

parthea commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Switching to draft until checks are green

@parthea parthea marked this pull request as draft April 17, 2026 15:38
@parthea

parthea commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

@jskeet , Please could you rebase this PR to include the fix from #16745?

@jskeet

jskeet commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

Will do as soon as my current generation task is done. It's all blocked on that :(

@jskeet jskeet force-pushed the generate-storage branch from ca5f7a0 to 28d8b67 Compare April 21, 2026 14:11
@jskeet

jskeet commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

@parthea Rebases and repushed. Let's see what happens.

@parthea parthea marked this pull request as ready for review April 21, 2026 14:21
@parthea

parthea commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

@jskeet PTAL at the conflict

Removed skip_generate and regenerated with Librarian.
@jskeet jskeet force-pushed the generate-storage branch from 28d8b67 to 0dc575c Compare April 21, 2026 14:24
@jskeet

jskeet commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

Rebased again, repushed...

@jskeet jskeet merged commit 668fec0 into googleapis:main Apr 21, 2026
30 checks passed
@jskeet jskeet deleted the generate-storage branch May 13, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants