feat(Storage): update StorageObject::exists to use HEAD request instead of GET#9196
Open
salilg-eng wants to merge 4 commits into
Open
feat(Storage): update StorageObject::exists to use HEAD request instead of GET#9196salilg-eng wants to merge 4 commits into
salilg-eng wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes / Addresses
Addresses b/437200793
Behavior Change & Motivation
Previously,
StorageObject::exists()invokedgetObject()(making an HTTPGETrequest) to verify if an object existed. Following a server-side enhancement to Google Cloud Storage Audit Logs, failedGETrequests against non-existent objects started emitting severityERRORlog messages rather thanINFO.Because checking whether an object exists is intended for workflows where an object may not be present, it should not generate false-alarm error severity records in Cloud Audit Logs or trigger unnecessary payload data downloads.
Technical Implementation
headObject()definition inConnectionInterfaceand implemented it inRest.StorageObject::exists()to useheadObject()(HTTPHEAD) instead ofgetObject()(HTTPGET).