Repository navigation
feat(storage): add StorageMetricsContext for operation metrics state - #14728
Open
nidhiii-27 wants to merge 7 commits into
Open
nidhiii-27 wants to merge 7 commits into
nidhiii-27 wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces StorageMetricsContext and its corresponding unit tests to manage operation metric state across asynchronous and thread-hopping boundaries. The review feedback suggests simplifying the API surface of StorageMetricsContext by making the primary constructor private, relying on static factory methods, and refactoring from(ApiCallContext) to delegate directly to from(GrpcCallContext) to eliminate duplicate logic. Additionally, the feedback recommends updating the unit tests to utilize these static factory methods instead of constructors.
nidhiii-27
force-pushed
the
feat/storage-metrics-context-error-mapping
branch
from
October 22, 2026 05:54
84a5ac6 to
ed62afa
Compare
…[Generated-by: AI]
nidhiii-27
force-pushed
the
feat/storage-metrics-context
branch
from
October 22, 2026 05:54
f943017 to
edb3def
Compare
…sContext [Generated-by: AI]
…torage-metrics-context
… [Generated-by: AI]
… recording [Generated-by: AI]
…d status overrides
…ring for unused transport [Generated-by: AI]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
StorageMetricsContextfor tracking per-operation and per-attempt OpenTelemetry metrics state.StorageMetricsContextto manage operation attributes, attempt counters, and durations.StorageMetricsContextTestunit tests.Stacked on #14694.