Repository navigation
test(spanner): unflake AsyncResultSetImplTest - #14656
Merged
Merged
Conversation
Production busy-spin hang in AsyncResultSetImpl when a ReadyCallback throws an exception, causing ProduceRowsRunnable to loop infinitely when buffer is full. Triggered by test race on paused flag in testCallbackIsNotCalledWhilePaused. Fixed by including cursorReturnedDoneOrException in producer stop condition and adding lock-based test synchronization.
sakthivelmanii
enabled auto-merge (squash)
October 14, 2026 16:00
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a potential hang in AsyncResultSetImpl where the producer thread could indefinitely wait for a full buffer to be consumed if the callback throws an exception. It introduces a shouldStopProducing() method to ensure the producer stops in such scenarios, adds synchronization to pause/resume logic in tests, and adds a new test case for this failure mode. The review feedback suggests using Mockito's timeout verification in the new test to prevent flakiness from asynchronous close operations.
olavloite
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production busy-spin hang in AsyncResultSetImpl when a ReadyCallback throws an exception, causing ProduceRowsRunnable to loop infinitely when buffer is full. Triggered by test race on paused flag in testCallbackIsNotCalledWhilePaused. Fixed by including cursorReturnedDoneOrException in producer stop condition and adding lock-based test synchronization.