Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the resumable upload stub generation and implementation to check if resumable upload is supported, returning a failing callable if it is not. It refactors the stub constructors to accept the callables and background resources directly rather than instantiating them internally, and updates the generator class HttpJsonServiceResumableUploadStubClassComposer accordingly. Feedback on the generator suggests passing resumableUploadMethods to createConstructorMethods and iterating over them to ensure the generated constructor parameter order deterministically matches the argument order in createStaticCreatorMethods, rather than relying on the iteration order of callableClassMembers.values().
4e04be2 to
653c982
Compare
…hannel is customized
653c982 to
fb386f8
Compare
|
|





Updates generated
HttpJson[Service]ResumableUploadStub.create()to detect customized gRPC transport configurations viaHttpJsonCallableFactory.isResumableUploadSupported(). When one is detected, the stub wires upload methods toHttpJsonCallableFactory.createFailingResumableUploadCallable()so client initialization and standard gRPC RPCs still succeed while upload calls fail with an informativeIllegalStateException.