Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces ResumableUploadTransportValidator to validate transport configurations on StubSettings for resumable uploads, exposing helper methods via HttpJsonCallableFactory. A review comment suggests adding a defensive null check for the transport channel provider in ResumableUploadTransportValidator to prevent a potential NullPointerException.
whowes
changed the title
whowes
added this pull request to stack #14654
October 13, 2026 23:24
whowes
force-pushed
the
whowes/resumable-upload-transport-detect
branch
from
October 13, 2026 23:33
61b4149 to
9ef8b1e
Compare
whowes
force-pushed
the
whowes/resumable-upload-transport-detect
branch
from
October 14, 2026 00:03
9ef8b1e to
5ecea13
Compare
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC clients bridge resumable uploads to HTTP/JSON using only top-level
StubSettings; pre-built channels or transport providers with direct endpoint, credentials, or header overrides are currently silently ignored rather than surfacing an actionable error.This PR adds
HttpJsonCallableFactory.isResumableUploadSupported()to detect incompatible transport providerscreateFailingResumableUploadCallable()that throws a deferred exception when an upload or resume call is invoked (stub initialization continues to be successful).