Repository navigation
Conversation
…esults and FieldValue
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the BigQuery client to propagate the full DataFormatOptions (including timestamp output format) instead of just a boolean useInt64Timestamps flag across BigQueryImpl, BigQueryOptions, FieldValue, FieldValueList, and HttpBigQueryRpc. Additionally, it optimizes timestamp parsing in FieldValue.getTimestampValue() by using Long.parseLong instead of allocating a BigInteger when useInt64Timestamps is enabled. Unit tests have been updated and a new test has been added to verify the propagation of these options to RPC requests. There are no review comments to address, and I have no further feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.