Repository navigation
perf(bigquery): defer blocking jobs.get RPC in QueryPageFetcher until getNextPage() - #14650
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors QueryPageFetcher in BigQueryImpl to lazily resolve the destination table on the first call to getNextPage() instead of in the constructor. This optimization avoids an unnecessary blocking jobs.get RPC when only the first page of results is consumed. Additionally, the class no longer extends Thread and removes the historical polling loop since the job is already complete when the fetcher is instantiated. Null-safety is improved when checking job completion, and redundant variable assignments are cleaned up. Corresponding unit tests have been added to verify these optimizations. I have no feedback to provide on these changes.
lqiu96
force-pushed
the
perf/bq-t1-15-lazy-jobs-get-pagination
branch
from
October 13, 2026 21:14
4b1750c to
302b1a9
Compare
lqiu96
enabled auto-merge (squash)
October 14, 2026 02:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defers the blocking
jobs.get(getJob(jobId)) RPC inBigQueryImpl.QueryPageFetcherfrom its constructor togetNextPage(), and removes the unusedThreadinheritance and 5-second status polling loop.