Skip to content

ci: set guice_custom_class_loading=OFF in unmanaged-dependency-check - #14620

Open
blakeli0 wants to merge 1 commit into
googleapis:mainfrom
blakeli0:fix-unmanaged-dependency-check-guice
Open

blakeli0 wants to merge 1 commit into
googleapis:mainfrom
blakeli0:fix-unmanaged-dependency-check-guice

Conversation

@blakeli0

@blakeli0 blakeli0 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Motivation

GitHub Actions ubuntu-22.04 runners recently upgraded pre-installed Maven from 3.9.16 to 3.10.0, which sets the JVM system property -Dguice_custom_class_loading=CHILD when starting Maven and routes java.util.logging output to stdout during exec:java.

Because unmanaged-dependency-check depends on com.google.cloud.tools:dependencies:1.5.13 (which pulls in com.google.inject:guice:4.2.1), running mvn exec:java logs a Guice warning (WARNING: CHILD is not a valid flag value for guice_custom_class_loading. Values must be one of [OFF, BRIDGE]) before printing [], causing sdk-platform-java Downstream Unmanaged Dependency Check to fail when comparing stdout against "[]".

Modifications

  • Configure guice_custom_class_loading=OFF in exec-maven-plugin <systemProperties> inside sdk-platform-java/java-shared-dependencies/unmanaged-dependency-check/pom.xml.

@blakeli0
blakeli0 requested a review from a team as a code owner October 9, 2026 19:54

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Maven configuration in pom.xml for the unmanaged-dependency-check tool, adding a system property guice_custom_class_loading set to OFF during execution. There are no review comments, and the changes are straightforward with no further feedback to provide.

@blakeli0 blakeli0 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2026
@blakeli0
blakeli0 requested a review from lqiu96 October 9, 2026 20:34

@lqiu96 lqiu96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two general questions (not blocking this PR specifically and can be looked at in the future):

  1. What is the unmanaged dependency check doing again? I don't recall this one and I wonder if this is one of those CIs that falls under the "needed in split repos but maybe not for the monorepo"
  2. Would it be possible to just upgrade/ override guice version instead? I think I would prefer to not have random configs unless there isn't any other option

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants