Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Maven configuration in pom.xml for the unmanaged-dependency-check tool, adding a system property guice_custom_class_loading set to OFF during execution. There are no review comments, and the changes are straightforward with no further feedback to provide.
lqiu96
approved these changes
Oct 9, 2026
lqiu96
left a comment
Member
There was a problem hiding this comment.
LGTM
Two general questions (not blocking this PR specifically and can be looked at in the future):
- What is the unmanaged dependency check doing again? I don't recall this one and I wonder if this is one of those CIs that falls under the "needed in split repos but maybe not for the monorepo"
- Would it be possible to just upgrade/ override guice version instead? I think I would prefer to not have random configs unless there isn't any other option
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GitHub Actions
ubuntu-22.04runners recently upgraded pre-installed Maven from3.9.16to3.10.0, which sets the JVM system property-Dguice_custom_class_loading=CHILDwhen starting Maven and routesjava.util.loggingoutput to stdout duringexec:java.Because
unmanaged-dependency-checkdepends oncom.google.cloud.tools:dependencies:1.5.13(which pulls incom.google.inject:guice:4.2.1), runningmvn exec:javalogs a Guice warning (WARNING: CHILD is not a valid flag value for guice_custom_class_loading. Values must be one of [OFF, BRIDGE]) before printing[], causingsdk-platform-java Downstream Unmanaged Dependency Checkto fail when comparing stdout against"[]".Modifications
guice_custom_class_loading=OFFinexec-maven-plugin<systemProperties>insidesdk-platform-java/java-shared-dependencies/unmanaged-dependency-check/pom.xml.