fix: revise health metrics inflightBytes to become inflightBytesMax

[agrawal-siddharth]

No description provided.

[gemini-code-assist]

Code Review

This pull request modifies ConnectionWorker to track and evaluate the maximum windowed inflight bytes (windowedInflightBytesMax) instead of the instantaneous inflight bytes during health checks. While the changes correctly update the health check metrics and tests, the review identified critical compilation errors where AtomicLong is passed directly to updateInflightBytesMax instead of calling .get(). Additionally, a thread-safety issue was found where windowedInflightBytesMax is updated without acquiring the required lock.

[gemini-code-assist]

The method updateInflightBytesMax expects a long primitive argument, but this.inflightBytes is an AtomicLong object. Passing it directly will cause a compilation error. Use this.inflightBytes.get() to retrieve the primitive value.

Suggested change

	healthCheckMetrics.updateInflightBytesMax(this.inflightBytes);
	healthCheckMetrics.updateInflightBytesMax(this.inflightBytes.get());

[gemini-code-assist]

The method updateInflightBytesMax expects a long primitive argument, but this.inflightBytes is an AtomicLong object. Passing it directly will cause a compilation error. Use this.inflightBytes.get() to retrieve the primitive value.

Suggested change

	healthCheckMetrics.updateInflightBytesMax(this.inflightBytes);
	healthCheckMetrics.updateInflightBytesMax(this.inflightBytes.get());

[gemini-code-assist]

The field windowedInflightBytesMax is annotated with @GuardedBy("lock"), but updateInflightBytesMax accesses and modifies it without acquiring the lock. This can lead to race conditions and thread-safety issues. In performance-sensitive code, prefer using explicit locks over the 'synchronized' keyword to protect shared state while ensuring thread safety and visibility.

    void updateInflightBytesMax(long currentInflightBytes) {
      lock.lock();
      try {
        if (currentInflightBytes > windowedInflightBytesMax) {
          windowedInflightBytesMax = currentInflightBytes;
        }
      } finally {
        lock.unlock();
      }
    }

References

1. In performance-sensitive code, prefer using explicit locks over the 'synchronized' keyword to protect shared state while ensuring thread safety and visibility.