Skip to content

test(spanner): unflake ITBulkConnectionTest.testBulkCreateConnectionsMultiThreaded - #14610

Merged
sakthivelmanii merged 1 commit into
mainfrom
unflake-b571072226-followup
Oct 8, 2026
Merged

sakthivelmanii merged 1 commit into
mainfrom
unflake-b571072226-followup

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #14604 to address review feedback on ITBulkConnectionTest.testBulkCreateConnectionsMultiThreaded:

  • Wrap the ExecutorService execution in a try-finally block calling executor.shutdownNow() and executor.awaitTermination(5L, TimeUnit.SECONDS) if the executor has not terminated when the test exits.
  • Include a descriptive failure message in assertTrue(..., executor.awaitTermination(60L, TimeUnit.SECONDS)) and use JUnit assertTrue / assertNotNull assertions inside the worker task.

…MultiThreaded

Ensure ExecutorService in ITBulkConnectionTest.testBulkCreateConnectionsMultiThreaded is always shut down in a try-finally block if the test fails, and use JUnit assertTrue/assertNotNull assertions.
@sakthivelmanii
sakthivelmanii requested review from a team as code owners October 8, 2026 17:03
@sakthivelmanii
sakthivelmanii enabled auto-merge (squash) October 8, 2026 17:03

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the multithreaded connection test in ITBulkConnectionTest.java to ensure proper cleanup of the ExecutorService using a try-finally block, while also updating some assertions to standard JUnit style. The review feedback recommends adding a null check for the executor and properly handling the potential InterruptedException during awaitTermination in the finally block to avoid swallowing the exception.

@sakthivelmanii
sakthivelmanii merged commit fe3be2d into main Oct 8, 2026
204 checks passed
@sakthivelmanii
sakthivelmanii deleted the unflake-b571072226-followup branch October 8, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants