Skip to content

chore(showcase): synchronize showcase definitions and generate client - #14306

Closed
whowes wants to merge 1 commit into
whowes/showcase-baseline-resumable-uploadfrom
whowes/showcase-client-generation
Closed

chore(showcase): synchronize showcase definitions and generate client#14306
whowes wants to merge 1 commit into
whowes/showcase-baseline-resumable-uploadfrom
whowes/showcase-client-generation

Conversation

@whowes

@whowes whowes commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Work in progress, not ready for review

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the resumable upload functionality (uploadMedia) in the ResumableUploadService to use the specialized ResumableUploadCallable and ResumableUploadCallSettings instead of standard unary callables. It introduces HttpJsonResumableUploadServiceResumableUploadStub to handle resumable uploads over HTTP/REST, requiring credentials even when using gRPC. Unit tests for uploadMedia are removed in favor of integration tests, and the corresponding async sample code is deleted. I have no feedback to provide as there are no review comments.

@whowes
whowes added this pull request to stack #14308 September 9, 2026 00:10
@whowes
whowes removed this pull request from stack #14308 September 9, 2026 02:59
@whowes
whowes force-pushed the whowes/showcase-client-generation branch from 102dc19 to ad3d894 Compare September 9, 2026 03:47
@whowes
whowes force-pushed the whowes/generator-resumable-upload-goldens branch from 40faed6 to 413a772 Compare September 9, 2026 03:47
Base automatically changed from whowes/generator-resumable-upload-goldens to whowes/showcase-baseline-resumable-upload September 9, 2026 03:47
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@whowes
whowes added this pull request to stack #14316 September 9, 2026 03:59
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@whowes whowes closed this Sep 9, 2026
@whowes
whowes removed this pull request from stack #14316 September 9, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@whowes