Skip to content

test(generator): add unit goldens for resumable upload stubs, client, and settings - #14305

Merged
whowes merged 1 commit into
whowes/showcase-baseline-resumable-uploadfrom
whowes/generator-resumable-upload-goldens
Sep 9, 2026
Merged

whowes merged 1 commit into
whowes/showcase-baseline-resumable-uploadfrom
whowes/generator-resumable-upload-goldens

Conversation

@whowes

@whowes whowes commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Work in progress, not yet ready for review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive support and testing for a new ResumableUploadService within the GAPIC generator for Java. It adds unit tests and corresponding golden files for both gRPC and HTTP/JSON (REST) stub classes, client classes, settings, and stub settings. Additionally, it includes generated sample code demonstrating asynchronous and synchronous media upload operations, as well as client initialization with custom credentials and endpoints. I have no feedback to provide as there are no review comments.

@whowes
whowes added this pull request to stack #14308 September 9, 2026 00:10
@whowes
whowes removed this pull request from stack #14308 September 9, 2026 02:59
@whowes
whowes force-pushed the whowes/generator-transport-stub-delegation branch from 1169a63 to daf1b64 Compare September 9, 2026 03:47
@whowes
whowes force-pushed the whowes/generator-resumable-upload-goldens branch from 40faed6 to 413a772 Compare September 9, 2026 03:47
Base automatically changed from whowes/generator-transport-stub-delegation to whowes/showcase-baseline-resumable-upload September 9, 2026 03:47
@whowes
whowes merged commit 413a772 into whowes/showcase-baseline-resumable-upload Sep 9, 2026
71 of 73 checks passed
@whowes
whowes deleted the whowes/generator-resumable-upload-goldens branch September 9, 2026 03:47
@whowes
whowes restored the whowes/generator-resumable-upload-goldens branch September 9, 2026 03:56
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant