Skip to content

test(spanner): unflake BuiltInMetricsCustomOpenTelemetryTest and BuiltInMetricsBothSinksTest #14282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sakthivelmanii merged 1 commit into from
Sep 7, 2026
Merged

test(spanner): unflake BuiltInMetricsCustomOpenTelemetryTest and BuiltInMetricsBothSinksTest #14282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...gle-cloud-spanner/src/test/java/com/google/cloud/spanner/BuiltInMetricsBothSinksTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ private static void executeSelect1(Spanner spanner) {
try (ResultSet resultSet = client.singleUse().executeQuery(SELECT1)) {
assertThat(resultSet.next()).isTrue();
assertThat(resultSet.getLong(0)).isEqualTo(1L);
assertThat(resultSet.next()).isFalse();
}
}

Expand Down
2 changes: 2 additions & 0 deletions ...spanner/src/test/java/com/google/cloud/spanner/BuiltInMetricsCustomOpenTelemetryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package com.google.cloud.spanner;

import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
Expand Down Expand Up @@ -79,6 +80,7 @@ private static void executeSelect1(Spanner spanner) {
try (ResultSet resultSet = client.singleUse().executeQuery(SELECT1)) {
assertTrue(resultSet.next());
assertThat(resultSet.getLong(0)).isEqualTo(1L);
assertFalse(resultSet.next());
Comment on lines 81 to +83

@gemini-code-assist gemini-code-assist Bot Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the rest of the assertions in this codebase and avoid mixing different assertion frameworks within the same block, please use Google Truth assertions (assertThat(...).isTrue() and assertThat(...).isFalse()) instead of JUnit's assertTrue and assertFalse. If you apply this change, you can also remove the unused import of org.junit.Assert.assertFalse at line 20.

Suggested change
assertTrue(resultSet.next());
assertThat(resultSet.getLong(0)).isEqualTo(1L);
assertFalse(resultSet.next());
assertThat(resultSet.next()).isTrue();
assertThat(resultSet.getLong(0)).isEqualTo(1L);
assertThat(resultSet.next()).isFalse();

}
}

Expand Down
Loading