Repository navigation
feat(firestore): add DML stages (Insert, Upsert) and atomic execution option to Java SDK pipelines - #14040
Open
wu-hui wants to merge 5 commits into
Open
feat(firestore): add DML stages (Insert, Upsert) and atomic execution option to Java SDK pipelines#14040wu-hui wants to merge 5 commits into
wu-hui wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the Insert and Upsert pipeline stages to the Firestore Pipeline API, along with an atomic execution option in PipelineExecuteOptions that automatically configures a read-write transaction. Unit and integration tests have been added to verify these new stages and execution options. The feedback suggests simplifying the toStageArgs method in Upsert.java by passing the map of expressions directly to PipelineUtils.encodeValue instead of manually iterating and encoding each entry.
wu-hui
force-pushed
the
feat-java-pipeline-dml
branch
from
August 21, 2026 19:17
665e375 to
88d498b
Compare
wu-hui
force-pushed
the
feat-java-pipeline-dml
branch
from
October 2, 2026 18:03
a56a5e2 to
c15ad03
Compare
… option to Java SDK pipelines - Implement Insert.java and Upsert.java stages in com.google.cloud.firestore.pipeline.stages - Add insert() and upsert() builder methods to Pipeline.java - Add withAtomic() option to PipelineExecuteOptions.java and wire proto request (newTransaction + autoCommitTransaction) - Add proto serialization unit tests in PipelineProtoTest.java - Add system integration test suite in ITPipelineTest.java covering insert, upsert, atomic execution, and transaction execution BUG=b/545136773 TAG=agy
wu-hui
force-pushed
the
feat-java-pipeline-dml
branch
from
October 6, 2026 19:31
9b0e512 to
f3c9c0b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds DML stages (
Insert,Upsert) and the atomic execution option to the Java SDK (java-firestore) Firestore Pipelines subsystem to achieve parity with Node and Web SDKs.Key Changes
Insert.java: Added new stage class forinsertoperation withcollectionreference anddocument_idexpression options.Upsert.java: Added new stage class forupsertoperation with transformation expressions argument,collectionreference, anddocument_idexpression options.PipelineExecuteOptions.java: AddedwithAtomic(boolean atomic)option.Pipeline.java:insert(...)andupsert(...)builder methods.executeInternalto populatenewTransaction(readWrite) andautoCommitTransaction = trueonExecutePipelineRequestwhenatomicis enabled.PipelineProtoTest.javaverifying proto generation forInsertandUpsertstages.ITPipelineTest.javacoveringinsert,upsertwith transforms,atomicoption, and transaction runner execution (transaction.execute(pipeline)).Buganizer Ticket
Fixes http://b/545136773 (under umbrella http://b/500350942)