fix(hermetic): exclude showcase modules from versions.txt#13029
Closed
fix(hermetic): exclude showcase modules from versions.txt#13029
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the fix_poms.py script to exclude modules containing "showcase" in their artifact ID from the versions.txt template rendering. The review feedback suggests using a more idiomatic Python list comprehension for this filtering and performing a case-insensitive check to ensure the exclusion is robust against naming variations.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
fix_poms.pyto completely exclude showcase-related modules (such asgapic-showcase,gapic-showcase-parent, etc.) fromversions.txt.fixes: #12914