fix(generator): align template and post-processor formatting#13028
Open
fix(generator): align template and post-processor formatting#13028
Conversation
blakeli0
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the formatting of owlbot.py and its Jinja2 template, specifically adjusting list item commas and closing brackets. A high-severity syntax error was identified in the template logic that would result in invalid Python code when template_excludes is provided, as it generates redundant closing parentheses. A fix was suggested to correctly handle the conditional closing of the function call.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the
owlbot.py.j2template with the formatting expected byupdate_owlbot_postprocessor_config.sh(no trailing comma on the last element and])closing tag), and synchronizes the existingowlbot.pyfiles.