Skip to content

Librarian generate diff check failed on main branch #13447

Closed

Description

@github-actions

The librarian generate diff check failed on main branch.

To keep the main branch healthy, please consider reverting the triggering change first. Once the revert is merged, you can investigate the failure and submit a new PR with the fix.

Please check the logs: https://github.com/googleapis/google-cloud-java/actions/runs/27380055184

Activity

  1. github-actions commented on Jun 11, 2026

    @github-actions
    Author

    @googleapis/cloud-sdk-librarian-team The workflow failed. Workflow Run: https://github.com/googleapis/google-cloud-java/actions/runs/27380055184

  2. github-actions commented on Jun 11, 2026

    @github-actions
    Author
  3. zhumin8 commented on Jun 12, 2026

    @zhumin8
    Contributor

    @blakeli0 I am updating this workflow to print git diff in log so it's easier to diagnose: #13450
    In the meantime, #13445 missed this one version

    <parent>
    <artifactId>google-cloud-pom-parent</artifactId>
    <groupId>com.google.cloud</groupId>
    <version>1.87.0</version><!-- {x-version-update:google-cloud-java:current} -->
    <relativePath>../google-cloud-pom-parent/pom.xml</relativePath>
    </parent>

  4. blakeli0 commented on Jun 12, 2026

    @blakeli0
    Contributor

    It is expected for partial release. We only bump version for gapic-libraries-bom, but not the parent pom google-cloud-pom-parent. However, since they share the same x-version-update:google-cloud-java:current, I think there would be diff failures for the time being.

    We may have to redesign the partial release process if we want to completely eliminate the diff. For example, maybe use one version for gapic-libraries-bom and another one for google-cloud-pom-parent.

  5. zhumin8 commented on Jun 12, 2026

    @zhumin8
    Contributor

    So after the partial release, until a next full release, version for gapic-libraries-bom and google-cloud-pom-parent will stay different?

    If so, we also need a different config item for librarian to correctly generate these.

  6. blakeli0 commented on Jun 12, 2026

    @blakeli0
    Contributor

    until a next full release

    until the next snapshot PR is merged, which might be more acceptable.

  7. zhumin8 commented on Jun 12, 2026

    @zhumin8
    Contributor

    Created googleapis/librarian#6411 for fixing this.
    In the meantime, leave this issue open to avoid new issue created due to this known generation diff during partial release.

    Removing "critical" label as issue is identified. Keep it assigned to @blakeli0 as this can resolve when snapshot is released.

  8. github-actions commented on Jun 12, 2026

    @github-actions
    Author
  9. github-actions commented on Jun 12, 2026

    @github-actions
    Author
  10. github-actions commented on Jun 13, 2026

    @github-actions
    Author
  11. github-actions commented on Jun 13, 2026

    @github-actions
    Author
  12. assigned and unassigned on Jun 13, 2026
  13. zhumin8 commented on Jun 13, 2026

    @zhumin8
    Contributor

    I am taking over this issue, will put in a manual on Monday.
    The latest failed run after snapshot PR #13456

    • Need to update partial release guide, to also update released_version in librarian.yaml
    • Will put in manual fix for versions in librarian.yaml
    • Investigate possible a bug in release-please/librarian for errorreporting case
  14. github-actions commented on Jun 14, 2026

    @github-actions
    Author
  15. github-actions commented on Jun 14, 2026

    @github-actions
    Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions