feat(bigtable): wrap admin client#14534
Conversation
product-auto-label
Bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the apiv2 administrative client for Cloud Bigtable, including the necessary generated code, documentation, and integration tests. The new AdminClient provides a modernized interface with helper methods like RestoreTable and WaitForReplication. I have identified an issue in the RestoreTable implementation where custom call options are not being passed to the long-running operation's Wait method, which would cause user-provided configurations to be ignored.
|
DO NOT MERGE. All the files in bigtable/admin/apiv2/ will be autogenerated once #14386 is merged except bigtable/admin/apiv2/table_admin_wrapper.go and bigtable/admin/apiv2/table_admin_wrapper_test.go. They have been included here only to pass the build. |
bhshkh
force-pushed
the
cbt-admin-modernization
branch
from
a3f8e96 to
4d899b5
Compare
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
bhshkh
force-pushed
the
cbt-admin-modernization
branch
3 times, most recently
from
3604956 to
b1c2e36
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces handwritten methods RestoreTable and WaitForReplication to the BigtableTableAdminClient, along with corresponding unit and integration tests. The review feedback suggests reducing the replication polling interval from 10 seconds to 1 second to prevent unnecessary latency. Additionally, it recommends updating TestWaitForReplication_ContextCancelled to cancel the context during the polling phase rather than immediately, ensuring that the polling loop's cancellation logic is actually tested.
bhshkh
force-pushed
the
cbt-admin-modernization
branch
from
0d4a24a to
0790391
Compare
bhshkh
changed the title
generated required files in #19962 and removed them from this pr |
|
not to be merged without @mutianf's approval |
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
A couple of minor nits. I'd also probably change the PR description since we're not wrapping the client in this case, we're simply adding handwritten methods to the generated client.
🤖 I have created a release *beep* *boop* --- ## [1.50.0](bigtable/v1.49.0...bigtable/v1.50.0) (2026-06-17) ### Features * **bigtable:** Enable JWT ([#19957](#19957)) ([af93528](af93528)) * **bigtable:** Generate Admin API client using selective gapic ([#19962](#19962)) ([a37509d](a37509d)) * **bigtable:** Refactor channel_pool_factory as we need to maintain two channel factory one for session and another for unary ([#14652](#14652)) ([0c0b6ce](0c0b6ce)) * **bigtable:** Wrap admin client ([#14534](#14534)) ([0bea4ba](0bea4ba)) * Update API sources and regenerate ([#19950](#19950)) ([c7607be](c7607be)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
3 participants
Design: go/cbt-admin-modernization-go