Skip to content

fix(ruby-wrapper): resolve flakiness on Windows and path warning #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olavloite wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −3
Open

fix(ruby-wrapper): resolve flakiness on Windows and path warning #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2779c5c
fix(ruby-wrapper): resolve flakiness on Windows and fix gemspec path …
olavloite Jun 11, 2026
833836c
fix(ruby-wrapper): run RuboCop linter fix
olavloite Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spannerlib/wrappers/spannerlib-ruby/spannerlib-ruby.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
spec.files = Dir.chdir(File.expand_path(__dir__)) do
files = []
# prefer git-tracked files when available (local dev), but also pick up built files present on disk (CI)
files += `git ls-files -z`.split("\x0") if system("git rev-parse --is-inside-work-tree > /dev/null 2>&1")
files += `git ls-files -z`.split("\x0") if system("git rev-parse --is-inside-work-tree > #{File::NULL} 2>&1")

# include any built native libs (CI places them under lib/spannerlib/)
files += Dir.glob("lib/spannerlib/**/*").select { |f| File.file?(f) }
Expand Down
13 changes: 11 additions & 2 deletions spannerlib/wrappers/spannerlib-ruby/spec/spannerlib_ruby_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
require "google/cloud/spanner/v1/spanner"
require "timeout"
require "tmpdir"
require "socket"

require_relative "mock_server/statement_result"
require_relative "../lib/spannerlib/ffi"
Expand Down Expand Up @@ -94,7 +95,15 @@ def self.wait_for_port

if File.exist?($port_file)
content = File.read($port_file).strip
return content.to_i unless content.empty?
unless content.empty?
port = content.to_i
begin
Socket.tcp("127.0.0.1", port, connect_timeout: 0.1) { nil }
return port
rescue SystemCallError
# Server not yet fully listening
end
Comment thread
olavloite marked this conversation as resolved.
end
end

raise "Mock server exited unexpectedly!" if Process.waitpid($server_pid, Process::WNOHANG)
Expand Down Expand Up @@ -170,7 +179,7 @@ def find_transaction_options(requests)
before do
self.class.ensure_server_running!
File.binwrite($mock_msg_file, Marshal.dump({}))
File.write($mock_req_file, "")
File.binwrite($mock_req_file, "")
@dsn = "127.0.0.1:#{$server_port}/projects/p/instances/i/databases/d?useplaintext=true"

@pool_id = SpannerLib.create_pool(@dsn)
Expand Down
Loading