feat: automatically set a default_sequence_kind on DDL failure#824
feat: automatically set a default_sequence_kind on DDL failure#824olavloite wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces automatic handling for DDL statement failures caused by a missing default sequence kind. When such an error is encountered and a 'default_sequence_kind' connection property is configured, the driver automatically executes an 'ALTER DATABASE' statement to set the default sequence kind and retries the remaining DDL statements. The changes also include corresponding unit tests and updates to the in-memory test server. The review feedback suggests simplifying the regular expression used to detect the missing sequence kind error by removing a redundant '.*' prefix.
|
Nice feature. When DDL execution fails due to a missing sequence kind, the driver automatically runs ALTER DATABASE to set the default sequence kind and retries the remaining statements. However, there is a bug in the error/metadata handling: |
1dcccfe to
ec646da
Compare
Done |
Introduces default_sequence_kind connection property. When DDL execution fails due to a missing sequence kind (detected via regex parsing of the Spanner error message), the driver automatically runs ALTER DATABASE to configure default_sequence_kind, and retries the remaining DDL statements.
Fixes #716