[xls][mlir] Fix issues found by MLIR's "expensive checks." - #4719
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
[xls][mlir] Fix issues found by MLIR's "expensive checks."#4719copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
This CL fixes several issues found in rewrite patterns by MLIR's `MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS`. Concretely, it fixes two issues: * A pattern in `-instantiate-eprocs` erased an op without going through the rewriter, so the CL uses `rewriter.eraseOp(op)` instead. * Two patterns in `-optimize-spawns` modified ops in place without going through `PatternRewriter::modifyOpInPlace`, so the CL moves the logic into a lambda and passes it to that function. PiperOrigin-RevId: 959590529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[xls][mlir] Fix issues found by MLIR's "expensive checks."
This CL fixes several issues found in rewrite patterns by MLIR's
MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS. Concretely, it fixes two issues:A pattern in
-instantiate-eprocserased an op without going through the rewriter, so the CL usesrewriter.eraseOp(op)instead.Two patterns in
-optimize-spawnsmodified ops in place without going throughPatternRewriter::modifyOpInPlace, so the CL moves the logic into a lambda and passes it to that function.